linux-kernel - Re: [PATCH v2 1/2] resource: Add device-managed request/release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140801135540.GA373@ulmo.nvidia.com>
Date:	Fri, 1 Aug 2014 15:55:42 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>,
	Stephen Warren <swarren@...dotorg.org>,
	linux-pci@...r.kernel.org, linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] resource: Add device-managed
 request/release_resource()

On Fri, Aug 01, 2014 at 08:55:22AM -0400, Tejun Heo wrote:
> On Fri, Aug 01, 2014 at 02:15:10PM +0200, Thierry Reding wrote:
> > From: Thierry Reding <treding@...dia.com>
> > 
> > Provide device-managed implementations of the request_resource() and
> > release_resource() functions. Upon failure to request a resource, the
> > new devm_request_resource() function will output an error message for
> > consistent error reporting.
> > 
> > Signed-off-by: Thierry Reding <treding@...dia.com>
> 
> Acked-by: Tejun Heo <tj@...nel.org>
> 
> But please also update Documentation/driver-model/devres.txt.

The patch already contains the below hunk. Do you expect anything more
to be added to that file?

Thierry

diff --git a/Documentation/driver-model/devres.txt b/Documentation/driver-model/devres.txt
index d14710b04439..befc3fe12ba6 100644
--- a/Documentation/driver-model/devres.txt
+++ b/Documentation/driver-model/devres.txt
@@ -264,8 +264,10 @@ IIO
 IO region
   devm_release_mem_region()
   devm_release_region()
+  devm_release_resource()
   devm_request_mem_region()
   devm_request_region()
+  devm_request_resource()

 IOMAP
   devm_ioport_map()

Content of type "application/pgp-signature" skipped