linux-kernel - Re: [scheduler] BUG: unable to handle kernel paging request at 000000000000ce50

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1408010855380.19843@gentwo.org>
Date:	Fri, 1 Aug 2014 08:58:52 -0500 (CDT)
From:	Christoph Lameter <cl@...two.org>
To:	Lai Jiangshan <laijs@...fujitsu.com>
cc:	Fengguang Wu <fengguang.wu@...el.com>, Tejun Heo <tj@...nel.org>,
	Jet Chen <jet.chen@...el.com>, Su Tao <tao.su@...el.com>,
	Yuanhan Liu <yuanhan.liu@...el.com>, LKP <lkp@...org>,
	linux-kernel@...r.kernel.org
Subject: Re: [scheduler] BUG: unable to handle kernel paging request at
 000000000000ce50

On Thu, 31 Jul 2014, Lai Jiangshan wrote:

> >     this_cpu_ptr instead.
>
>
> -	struct cpumask *cpus = __get_cpu_var(load_balance_mask);
> +	struct cpumask *cpus = this_cpu_ptr(load_balance_mask);
>
>
> I think the conversion is wrong. it should be
> 			*this_cpu_ptr(&load_balance_mask);

Hmmm.... that is going to cause some pretty strange looking code. Would
the compiler/sparse not complain if the wrong type of pointer is assigned
to?


If we are retrieving a pointer then the right way to do things would be:

cpus = this_cpu_read(load_balance_mask);



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/