linux-kernel - Re: [PATCH 8/8] Replacing spinlocks by nx_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140801142606.GB14651@gondor.apana.org.au>
Date:	Fri, 1 Aug 2014 22:26:06 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Leonidas Da Silva Barbosa <leosilva@...ux.vnet.ibm.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	mhcerri@...ux.vnet.ibm.com, fin@...ux.vnet.ibm.com
Subject: Re: [PATCH 8/8] Replacing spinlocks by nx_copy_ctx on NX-SHA256 and
 NX-SHA512

On Thu, Jul 24, 2014 at 11:02:45AM -0300, Leonidas Da Silva Barbosa wrote:
> Replaces spinlock usage by a simple copy of the crypto context, avoiding
> possible bottlenecks.
> 
> Signed-off-by: Leonidas Da Silva Barbosa <leosilva@...ux.vnet.ibm.com>

While your patches look OK, it appears that the underlying hash
code is completely broken when it's used by multiple users because
it stores the hash state in the tfm context.

If this is the case we should disable the hash part of the driver
until it's fixed properly.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/