linux-kernel - Re: [PATCH 2/2] dma: imx-sdma: Adding tasklet_kill() in sdma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 1 Aug 2014 22:15:24 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Vignesh Raman <Vignesh_Raman@...tor.com>
Cc:	dan.j.williams@...el.com, dmaengine@...r.kernel.org,
	linux-kernel@...r.kernel.org, Jiada_Wang@...tor.com
Subject: Re: [PATCH 2/2] dma: imx-sdma: Adding tasklet_kill() in
 sdma_remove function.

On Fri, Aug 01, 2014 at 07:36:53PM +0530, Vignesh Raman wrote:
> On Thursday 31 July 2014 05:32 PM, Vinod Koul wrote:
> > On Wed, Jul 30, 2014 at 06:41:15PM +0530, Vignesh Raman wrote:
> >> Several dma drivers calls tasklet_kill() in remove function. This is missing in
> >> imx driver, so adding tasklet_kill() in sdma_remove function.
> > And why should we do that ?
> > 
> This is done because all running tasklets should be killed on remove.

And what prevents is from mentioning this in changelog!

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/