linux-kernel - Re: [PATCHv10 4/4] dt: mailbox: add generic bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140801184314.GM30458@sirena.org.uk>
Date:	Fri, 1 Aug 2014 19:43:14 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Jassi Brar <jaswinder.singh@...aro.org>
Cc:	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	ks.giri@...sung.com, arnd@...db.de, ijc+devicetree@...lion.org.uk,
	mark.rutland@....com, robh+dt@...nel.org, pawel.moll@....com,
	courtney.cavin@...ymobile.com, mporter@...aro.org,
	slapdau@...oo.com.au, lftan.linux@...il.com, loic.pallardy@...com,
	s-anna@...com, ashwin.chaugule@...aro.org, bjorn@...o.se,
	patches@...aro.org, mollie.wu@...aro.org,
	t.takinishi@...fujitsu.com, khilman@...aro.org,
	lee.jones@...aro.org, andy.green@...aro.org
Subject: Re: [PATCHv10 4/4] dt: mailbox: add generic bindings

On Fri, Aug 01, 2014 at 06:02:45PM +0530, Jassi Brar wrote:

> +Optional property:
> +- mbox-names: List of identifier strings for each mailbox channel
> +		required by the client. The use of this property
> +		is discouraged in favor of using index in list of
> +		'mboxes' while requesting a mailbox.

Can I suggest that if we do want to avoid strings for some reason (it's
not obvious to me why) then we include a recommendation to provide
defines in a header file in order to improve legibility.  That's pretty
minor, though.

Reviewed-by: Mark Brown <broonie@...aro.org>

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)