linux-kernel - Re: [PATCH v2 0/3 net-next] Lockless netlink_lookup() with new concurrent hash table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140731.223946.2222491319947824077.davem@davemloft.net>
Date:	Thu, 31 Jul 2014 22:39:46 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	tgraf@...g.ch
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kaber@...sh.net, paulmck@...ux.vnet.ibm.com, josh@...htriplett.org,
	challa@...ronetworks.com, walpole@...pdx.edu, dev@...nvswitch.org,
	tklauser@...tanz.ch, netfilter-devel@...r.kernel.org
Subject: Re: [PATCH v2 0/3 net-next] Lockless netlink_lookup() with new
 concurrent hash table

From: Thomas Graf <tgraf@...g.ch>
Date: Fri,  1 Aug 2014 00:56:00 +0200

> Netlink sockets are maintained in a hash table to allow efficient lookup
> via the port ID for unicast messages. However, lookups currently require
> a read lock to be taken. This series adds a new generic, resizable,
> scalable, concurrent hash table based on the paper referenced in the first
> patch. It then makes use of the new data type to implement lockless
> netlink_lookup().
> 
> Patch 3/3 to convert nft_hash is included for reference but should be
> merged via the netfilter tree. Inclusion in this series is to provide
> context for the suggested API.
> 
> Against net-next since the initial user of the new hash table is in net/
> 
> Changes:
> v1-v2:
>  - fixed traversal off-by-one as spotted by Tobias Klauser
>  - removed unlikely() from BUG_ON() as spotted by Josh Triplett
>  - new 3rd patch to convert nft_hash to rhashtable
>  - make rhashtable_insert() return void
>  - nl_sk_hash_lock must be a mutex
>  - fixed wrong name of rht_shrink_below_30()
>  - exported symbols rht_grow_above_75() and rht_shrink_below_30()
>  - allow table freeing with RCU callback

Looks great, series applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/