lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 02 Aug 2014 09:49:53 +0200 From: Andreas Färber <afaerber@...e.de> To: Doug Anderson <dianders@...omium.org>, Tomasz Figa <tomasz.figa@...il.com> CC: linux-samsung-soc <linux-samsung-soc@...r.kernel.org>, Vincent Palatin <vpalatin@...omium.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, Stephan van Schaik <stephan@...khronix.com>, Javier Martinez Canillas <javier.martinez@...labora.co.uk>, Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Russell King <linux@....linux.org.uk>, Ben Dooks <ben-linux@...ff.org>, Kukjin Kim <kgene.kim@...sung.com>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree Am 02.08.2014 07:15, schrieb Doug Anderson: > On Thu, Jul 31, 2014 at 12:40 PM, Tomasz Figa <tomasz.figa@...il.com> wrote: >> On 31.07.2014 21:20, Andreas Färber wrote: >>> Am 31.07.2014 21:05, schrieb Tomasz Figa: >>>> On 31.07.2014 18:08, Andreas Färber wrote: >>>>> +&sd1_clk { >>>>> + samsung,pin-drv = <0>; >>>>> +}; >>>>> + >>>>> +&sd1_cmd { >>>>> + samsung,pin-pud = <3>; >>>>> + samsung,pin-drv = <0>; >>>>> +}; >>>>> + >>>>> +&sd1_cd { >>>>> + samsung,pin-drv = <0>; >>>>> +}; >>>>> + >>>>> +&sd1_bus4 { >>>>> + samsung,pin-drv = <0>; >>>>> +}; >>>> >>>> Here generic settings are being overridden, so it might be a good idea >>>> to explain why, like with i2c pull-up above. >>> >>> Snow does not have an explanation either, so please suggest what comment >>> you'd like to see. Consider me just a user with no specs. :) >> >> Doug, Vincent, someone else? > > The comment is just in a different place--it's in the dw_mmc node. > Probably belongs here, though: > > /* > * Wifi is a SiP, so can keep drive strengths low > * to reduce EMI. > */ > I did copy such a comment for the MMC node in v5, still present in v6. Andreas > I guess the cmd line isn't documented. There is no external pull on > the command line and on most boards there is one. Our hardware guys > thought we didn't need it and apparently we don't... -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists