linux-kernel - Re: [PATCH] staging: iio: ad9832: Use devm_iio_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2af09d4e-10c7-4887-a29c-0d31b0ac6493@email.android.com>
Date:	Sun, 03 Aug 2014 11:22:58 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Himangi Saraogi <himangi774@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
CC:	julia.lawall@...6.fr
Subject: Re: [PATCH] staging: iio: ad9832: Use devm_iio_device_register



On August 3, 2014 10:56:58 AM GMT+01:00, Himangi Saraogi <himangi774@...il.com> wrote:
>This patch introduces the use of devm_iio_device_register and does away
>with the unregister in the remove function.
>
And changes the resulting ordering so the regulator disable occurs before the user
 space interface has been removed by the unregister. 

Please be very wary of using devm_iio_register. It is only correct if the remove function does nothing else.

Jonathan
>Signed-off-by: Himangi Saraogi <himangi774@...il.com>
>Acked-by: Julia Lawall <julia.lawall@...6.fr>
>---
> drivers/staging/iio/frequency/ad9832.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/staging/iio/frequency/ad9832.c
>b/drivers/staging/iio/frequency/ad9832.c
>index cf68159..8a72c78 100644
>--- a/drivers/staging/iio/frequency/ad9832.c
>+++ b/drivers/staging/iio/frequency/ad9832.c
>@@ -304,7 +304,7 @@ static int ad9832_probe(struct spi_device *spi)
> 	if (ret)
> 		goto error_disable_reg;
> 
>-	ret = iio_device_register(indio_dev);
>+	ret = devm_iio_device_register(&spi->dev, indio_dev);
> 	if (ret)
> 		goto error_disable_reg;
> 
>@@ -322,7 +322,6 @@ static int ad9832_remove(struct spi_device *spi)
> 	struct iio_dev *indio_dev = spi_get_drvdata(spi);
> 	struct ad9832_state *st = iio_priv(indio_dev);
> 
>-	iio_device_unregister(indio_dev);
> 	if (!IS_ERR(st->reg))
> 		regulator_disable(st->reg);
> 

-- 
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/