linux-kernel - Re: [PATCH 3/4] Add the "verbose" module option.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140803175222.3433b646@endymion.delvare>
Date:	Sun, 3 Aug 2014 17:52:22 +0200
From:	Jean Delvare <jdelvare@...e.de>
To:	kreijack@...ind.it
Cc:	kreijack@...il.com,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	linux-kernel@...r.kernel.org, bryan@...troute.net
Subject: Re: [PATCH 3/4] Add the "verbose" module option.

On Sun, 03 Aug 2014 17:12:57 +0200, Goffredo Baroncelli wrote:
> On 08/03/2014 04:12 PM, Jean Delvare wrote:
> >> +	    (verbose > 0 && level >= 0)) {
> >> +		print_temp("CPU-temp: ", temp );
> >> +		if (casetemp)
> >> +			print_temp(", Case: ", casetemp );
> >> +		if (level >= 0)
> >> +			printk(", Fan: %d (tuned %+d)\n", 11-level,
> >> +				x.fan_level-level );
> >> +		else
> >> +			printk(", Fan: %d (tuned +0)\n",x.fan_level);
> > 
> > I think you can do without the "tuned +0" which doesn't add much value.
> 
> Me too. But the old driver does the same, so I preferred to 
> leave it as is.

I looked at the code again and no, I can't see the old code doing that.
It has "tuned %+d" only in tune_fan() which is only called if
level >= 0. The other printk (when tune_fan isn't called) doesn't have
a "tuned" part.

-- 
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/