[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140804083823.GO8181@intel.com>
Date: Mon, 4 Aug 2014 14:08:23 +0530
From: Vinod Koul <vinod.koul@...el.com>
To: Vignesh Raman <Vignesh_Raman@...tor.com>
Cc: dan.j.williams@...el.com, dmaengine@...r.kernel.org,
linux-kernel@...r.kernel.org, Jiada_Wang@...tor.com
Subject: Re: [PATCH 1/2] dma: imx-sdma: use module_platform_driver for SDMA
driver
On Mon, Aug 04, 2014 at 02:11:01PM +0530, Vignesh Raman wrote:
> On Thursday 31 July 2014 05:30 PM, Vinod Koul wrote:
> > On Wed, Jul 30, 2014 at 06:41:14PM +0530, Vignesh Raman wrote:
> >> Currently there is no module_exit declared in SDMA driver, so that once
> >> sdma module is inserted, it's shown with permanent attribute by lsmod,
> >> and it can't be removed.
> >> Use module_platform_driver to register/unregister SDMA driver and modify
> >> SDMA's remove operation, to make SDMA driver possible to be removed.
> > where is this bit below?
> >
> I'm not clear with your question. Are you asking about the unregister
> SDMA driver function? It is done by dma_async_device_unregister.
Driver already uses module_platform_driver, so I dont see what information
the last two lines are trying to convey.
Patch needs to talk about what is done in current patch
--
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists