linux-kernel - Re: [PATCH V3] Save command pool address of Scsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53DF6BBD.2060206@suse.com>
Date:	Mon, 04 Aug 2014 13:17:17 +0200
From:	Juergen Gross <jgross@...e.com>
To:	Christoph Hellwig <hch@...radead.org>
CC:	James.Bottomley@...senPartnership.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3] Save command pool address of Scsi_Host

On 08/04/2014 01:08 PM, Christoph Hellwig wrote:
> On Mon, Aug 04, 2014 at 06:26:09AM +0200, jgross@...e.com wrote:
>> From: Juergen Gross <jgross@...e.com>
>>
>> If a scsi host driver specifies .cmd_len in it's scsi_host_template, a driver's
>> private command pool is needed. scsi_find_host_cmd_pool() will locate it, but
>> scsi_alloc_host_cmd_pool() isn't saving the pool address in the host template.
>>
>> This will result in an access error when the host is removed.
>>
>> Avoid the problem by saving the address of a new allocated command pool where
>> it is expected and delete it again when the pool is destroyed.
>
> I don't really like the double pointer passing - just NULLing out the
> pointer in the caller where needed seems cleaner.

I wanted to avoid to spread this, but I don't mind doing it. V4 is
coming...


Juergen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/