linux-kernel - Re: checkpatch.pl report about "Missing blank line after declarations" in a structure definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1407159342.16152.63.camel@joe-AO725>
Date:	Mon, 04 Aug 2014 06:35:42 -0700
From:	Joe Perches <joe@...ches.com>
To:	Dotan Barak <dotanb@...lanox.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: checkpatch.pl report about "Missing blank line after
 declarations" in a structure definition

On Mon, 2014-08-04 at 11:20 +0000, Dotan Barak wrote:
> Hi Joe.
> 
> Thanks for fixing the issue that I reported about.
> 
> It seems that even after your fix, there is still a false warning of "Missing blank line after declarations".
> 
> I executed checkpatch.pl on a header file that exists in the Linux tree:
> # ./checkpatch.pl --file --no-tree ../include/linux/mlx5/cq.h
> 
> And got the following warning:
> 
> WARNING: Missing a blank line after declarations
> #49: FILE: ../include/linux/mlx5/cq.h:49:
> +       int                     irqn;
> +       void (*comp)            (struct mlx5_core_cq *);
[]
> As you can see, this is a structure definition and IMHO the warning above is false.

The version in Linus' tree has a defect where
this test doesn't recognize function pointer
declarations.

This is fixed in -next since June, but it takes
awhile to get into Linus' tree.

https://lkml.org/lkml/2014/6/6/426


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/