linux-kernel - Re: [PATCH 08/19] gru: fix %d confusingly prefixed with 0x in format string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140804133037.GA31042@sgi.com>
Date:	Mon, 4 Aug 2014 08:30:37 -0500
From:	Dimitri Sivanich <sivanich@....com>
To:	Hans Wennborg <hans@...shq.net>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/19] gru: fix %d confusingly prefixed with 0x in
 format string

Decimal ("%d" without the "0x") for the ctxnum please.

Nacked-by: Dimitri Sivanich <sivanich@....com>

On Sun, Aug 03, 2014 at 05:19:37PM -0700, Hans Wennborg wrote:
> Signed-off-by: Hans Wennborg <hans@...shq.net>
> ---
>  drivers/misc/sgi-gru/grumain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c
> index ae16c8c..a1ce324 100644
> --- a/drivers/misc/sgi-gru/grumain.c
> +++ b/drivers/misc/sgi-gru/grumain.c
> @@ -283,7 +283,7 @@ static void gru_unload_mm_tracker(struct gru_state *gru,
>  	spin_lock(&gru->gs_asid_lock);
>  	BUG_ON((asids->mt_ctxbitmap & ctxbitmap) != ctxbitmap);
>  	asids->mt_ctxbitmap ^= ctxbitmap;
> -	gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n",
> +	gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%x, asidmap 0x%lx\n",
>  		gru->gs_gid, gts, gms, gts->ts_ctxnum, gms->ms_asidmap[0]);
>  	spin_unlock(&gru->gs_asid_lock);
>  	spin_unlock(&gms->ms_asid_lock);
> -- 
> 2.0.0.526.g5318336
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/