linux-kernel - Re: [PATCH] Hibernate: check unsafe page should not in e820 reserved region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140804145640.GE16024@linux-rxt1.site>
Date:	Mon, 4 Aug 2014 22:56:40 +0800
From:	joeyli <jlee@...e.com>
To:	Pavel Machek <pavel@....cz>
Cc:	Takashi Iwai <tiwai@...e.de>,
	"Lee, Chun-Yi" <joeyli.kernel@...il.com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <len.brown@...el.com>, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Hibernate: check unsafe page should not in e820 reserved
 region

Hi Pavel, 

Thanks for your review!

On Mon, Aug 04, 2014 at 03:08:11PM +0200, Pavel Machek wrote:
> > > +
> > > +	list_for_each_entry(region, &nosave_regions, list) {
> > > +		if (pfn >= region->start_pfn && pfn < region->end_pfn) {
> > > +			pr_err("PM: %#010llx in e820 nosave regsion: "
> 
> And while looking at it, this should probably be spelled "region".
>  
> ...plus maybe past part of changelog here into the comment?
> 

Oh, sorry for my typo! I will correct it and comment in next version. 

> Otherwise looks good to me, 
> 
> Acked-by: Pavel Machek <pavel@....cz>
> 									Pavel

Regards
Joey Lee
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/