linux-kernel - RE: [PATCH 15/18 v2] staging: comedi: amplc_pci224: put board indices in PCI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DC148C5AA1CEBA4E87973D432B1C2D8825F40E85@P3PWEX4MB008.ex4.secureserver.net>
Date:	Mon, 4 Aug 2014 16:38:34 +0000
From:	Hartley Sweeten <HartleyS@...ionengravers.com>
To:	Ian Abbott <abbotti@....co.uk>,
	"driverdev-devel@...uxdriverproject.org" 
	<driverdev-devel@...uxdriverproject.org>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 15/18 v2] staging: comedi: amplc_pci224: put board
 indices in PCI driver_data

On Monday, August 04, 2014 4:14 AM, Ian Abbott wrote:
> The `driver_data` member value from the matched entry of the PCI module
> device table `amplc_pci224_pci_table[]` is passed through to our comedi
> "auto_attach" handler, `pci224_auto_attach()`.  Use that to index
> directly into our static board data array `pci224_boards[]` instead of
> calling `pci224_find_pci_board()` to search for the entry matching the
> PCI device ID.  That function can be removed.  The `devid` and `model`
> members of `struct pci224_board` are no longer needed either and can be
> removed.
>
> Signed-off-by: Ian Abbott <abbotti@....co.uk>
> ---
> v2: Use C99 syntax for amplc_pci224_pci_table[] initializer.  Thanks to
> Hartley for finding that!

Reviewed-by: H Hartley Sweeten <hsweeten@...ionengravers.com>

Thanks,
Hartley

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/