| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 04 Aug 2014 17:48:31 +0100 From: Ben Hutchings <ben@...adent.org.uk> To: linux-kernel@...r.kernel.org, stable@...r.kernel.org CC: akpm@...ux-foundation.org, "Axel Lin" <axel.lin@...ics.com>, "Guenter Roeck" <linux@...ck-us.net> Subject: [PATCH 3.2 25/94] hwmon: (adm1029) Ensure the fan_div cache is updated in set_fan_div 3.2.62-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Axel Lin <axel.lin@...ics.com> commit 1035a9e3e9c76b64a860a774f5b867d28d34acc2 upstream. Writing to fanX_div does not clear the cache. As a result, reading from fanX_div may return the old value for up to two seconds after writing a new value. This patch ensures the fan_div cache is updated in set_fan_div(). Reported-by: Guenter Roeck <linux@...ck-us.net> Signed-off-by: Axel Lin <axel.lin@...ics.com> Signed-off-by: Guenter Roeck <linux@...ck-us.net> Signed-off-by: Ben Hutchings <ben@...adent.org.uk> --- drivers/hwmon/adm1029.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/hwmon/adm1029.c +++ b/drivers/hwmon/adm1029.c @@ -228,6 +228,9 @@ static ssize_t set_fan_div(struct device /* Update the value */ reg = (reg & 0x3F) | (val << 6); + /* Update the cache */ + data->fan_div[attr->index] = reg; + /* Write value */ i2c_smbus_write_byte_data(client, ADM1029_REG_FAN_DIV[attr->index], reg); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists