linux-kernel - Re: [PATCH v1.3 4/18] arcmsr: limit max. number of SCSI command request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1407124855.5217.23.camel@Centos6.3-64>
Date:	Mon, 04 Aug 2014 12:00:55 +0800
From:	Ching Huang <ching2048@...ca.com.tw>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	jbottomley@...allels.com, dan.carpenter@...cle.com,
	thenzl@...hat.com, agordeev@...hat.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1.3 4/18] arcmsr: limit max. number of SCSI command
 request

On Fri, 2014-08-01 at 05:35 -0700, Christoph Hellwig wrote:
> > @@ -2220,8 +2220,7 @@ static int arcmsr_queue_command_lck(stru
> >  		arcmsr_handle_virtual_command(acb, cmd);
> >  		return 0;
> >  	}
> > -	if (atomic_read(&acb->ccboutstandingcount) >=
> > -			ARCMSR_MAX_OUTSTANDING_CMD)
> > +	if (atomic_read(&acb->ccboutstandingcount) >= acb->maxOutstanding)
> >  		return SCSI_MLQUEUE_HOST_BUSY;
> 
> The scsi midlayer already takes care of this check for you.
> 

Hello Christoph,

We have 4 types of Adapter that some adpaters have command queue less
than ARCMSR_MAX_OUTSTANDING_CMD.
So we have to check outstanding command number here.

Thanks for your comment.
Ching

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/