linux-kernel - Re: Question regarding "Control Dependencies" in memory-barriers.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140804185226.GQ8101@linux.vnet.ibm.com>
Date:	Mon, 4 Aug 2014 11:52:26 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Pranith Kumar <pranith@...ech.edu>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: Question regarding "Control Dependencies" in memory-barriers.txt

On Mon, Aug 04, 2014 at 01:07:47PM -0400, Pranith Kumar wrote:
> The section "Control Dependencies" in memory-barriers.txt has the
> following text:
> 
> 662 In addition, you need to be careful what you do with the local variable 'q',
> 663 otherwise the compiler might be able to guess the value and again remove
> 664 the needed conditional.  For example:
> 665
> 666         q = ACCESS_ONCE(a);
> 667         if (q % MAX) {
> 668                 barrier();
> 669                 ACCESS_ONCE(b) = p;
> 670                 do_something();
> 671         } else {
> 672                 barrier();
> 673                 ACCESS_ONCE(b) = p;
> 674                 do_something_else();
> 675         }
> 676
> 677 If MAX is defined to be 1, then the compiler knows that (q % MAX) is
> 678 equal to zero, in which case the compiler is within its rights to
> 679 transform the above code into the following:
> 680
> 681         q = ACCESS_ONCE(a);
> 682         ACCESS_ONCE(b) = p;
> 683         do_something_else();
> 
> Given that there is an explicit barrier() in both the branches of
> if/else statement, how can the above transformation happen? The
> compiler cannot just remove the barrier(), right?

No, the compiler cannot just remove the barrier().  However, it can
notice that "q % MAX" is always zero, which allows it to throw away
the then-clause entirely.

> I think it will transform to the following if MAX is defined to 1:
> 
> q = ACCESS_ONCE(a);
> barrier();
> ACCESS_ONCE(b) = p;
> do_something_else();

Good point, the "barrier()" must be retained, but...

> and hence the ordering will be preserved. What am I missing here?

Because the barrier() primitive affects only the compiler, the CPU
can still reorder things.

In contrast, in the original, the control dependency implied by the "if"
statement prevents the CPU from reordering.

I fixed the example to retain the barrier() with your Reported-by.

						Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/