linux-kernel - Re: [patch 2/4] mm: Use may_adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140804202548.GC27304@mail.hallyn.com>
Date:	Mon, 4 Aug 2014 22:25:48 +0200
From:	"Serge E. Hallyn" <serge@...lyn.com>
To:	Cyrill Gorcunov <gorcunov@...nvz.org>
Cc:	linux-kernel@...r.kernel.org, keescook@...omium.org, tj@...nel.org,
	akpm@...ux-foundation.org, avagin@...nvz.org,
	ebiederm@...ssion.com, hpa@...or.com, serge.hallyn@...onical.com,
	xemul@...allels.com, segoon@...nwall.com,
	kamezawa.hiroyu@...fujitsu.com, mtk.manpages@...il.com,
	jln@...gle.com
Subject: Re: [patch 2/4] mm: Use may_adjust_brk helper

Quoting Cyrill Gorcunov (gorcunov@...nvz.org):
> Signed-off-by: Cyrill Gorcunov <gorcunov@...nvz.org>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Tejun Heo <tj@...nel.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Andrew Vagin <avagin@...nvz.org>
> Cc: Eric W. Biederman <ebiederm@...ssion.com>
> Cc: H. Peter Anvin <hpa@...or.com>
> Cc: Serge Hallyn <serge.hallyn@...onical.com>

Acked-by: Serge Hallyn <serge.hallyn@...onical.com>

> Cc: Pavel Emelyanov <xemul@...allels.com>
> Cc: Vasiliy Kulikov <segoon@...nwall.com>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> Cc: Michael Kerrisk <mtk.manpages@...il.com>
> Cc: Julien Tinnes <jln@...gle.com>
> ---
>  kernel/sys.c |   11 ++++-------
>  mm/mmap.c    |    7 +++----
>  2 files changed, 7 insertions(+), 11 deletions(-)
> 
> Index: linux-2.6.git/kernel/sys.c
> ===================================================================
> --- linux-2.6.git.orig/kernel/sys.c
> +++ linux-2.6.git/kernel/sys.c
> @@ -1693,7 +1693,6 @@ exit:
>  static int prctl_set_mm(int opt, unsigned long addr,
>  			unsigned long arg4, unsigned long arg5)
>  {
> -	unsigned long rlim = rlimit(RLIMIT_DATA);
>  	struct mm_struct *mm = current->mm;
>  	struct vm_area_struct *vma;
>  	int error;
> @@ -1733,9 +1732,8 @@ static int prctl_set_mm(int opt, unsigne
>  		if (addr <= mm->end_data)
>  			goto out;
>  
> -		if (rlim < RLIM_INFINITY &&
> -		    (mm->brk - addr) +
> -		    (mm->end_data - mm->start_data) > rlim)
> +		if (check_data_rlimit(rlimit(RLIMIT_DATA), mm->brk, addr,
> +				      mm->end_data, mm->start_data))
>  			goto out;
>  
>  		mm->start_brk = addr;
> @@ -1745,9 +1743,8 @@ static int prctl_set_mm(int opt, unsigne
>  		if (addr <= mm->end_data)
>  			goto out;
>  
> -		if (rlim < RLIM_INFINITY &&
> -		    (addr - mm->start_brk) +
> -		    (mm->end_data - mm->start_data) > rlim)
> +		if (check_data_rlimit(rlimit(RLIMIT_DATA), addr, mm->start_brk,
> +				      mm->end_data, mm->start_data))
>  			goto out;
>  
>  		mm->brk = addr;
> Index: linux-2.6.git/mm/mmap.c
> ===================================================================
> --- linux-2.6.git.orig/mm/mmap.c
> +++ linux-2.6.git/mm/mmap.c
> @@ -263,7 +263,7 @@ static unsigned long do_brk(unsigned lon
>  
>  SYSCALL_DEFINE1(brk, unsigned long, brk)
>  {
> -	unsigned long rlim, retval;
> +	unsigned long retval;
>  	unsigned long newbrk, oldbrk;
>  	struct mm_struct *mm = current->mm;
>  	unsigned long min_brk;
> @@ -293,9 +293,8 @@ SYSCALL_DEFINE1(brk, unsigned long, brk)
>  	 * segment grow beyond its set limit the in case where the limit is
>  	 * not page aligned -Ram Gupta
>  	 */
> -	rlim = rlimit(RLIMIT_DATA);
> -	if (rlim < RLIM_INFINITY && (brk - mm->start_brk) +
> -			(mm->end_data - mm->start_data) > rlim)
> +	if (check_data_rlimit(rlimit(RLIMIT_DATA), brk, mm->start_brk,
> +			      mm->end_data, mm->start_data))
>  		goto out;
>  
>  	newbrk = PAGE_ALIGN(brk);
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/