linux-kernel - Re: [PATCH] xhci: Merge and Update debugging for patches from 3.6 kernel tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 Aug 2014 09:05:48 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Nick Krause <xerofoify@...il.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	"Nyman, Mathias" <mathias.nyman@...el.com>,
	Alan Stern <stern@...land.harvard.edu>,
	Deepak Saxena <dsaxena@...aro.org>,
	"manjunath.goudar" <manjunath.goudar@...aro.org>,
	"jg1.han" <jg1.han@...sung.com>, davidm <davidm@...uge.net>,
	Ksenia Ragiadakou <burzalodowa@...il.com>,
	hartleys <hartleys@...ionengravers.com>,
	"gregory.clement" <gregory.clement@...e-electrons.com>,
	oneukum <oneukum@...e.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	USB list <linux-usb@...r.kernel.org>
Subject: Re: [PATCH] xhci: Merge and Update debugging for patches from 3.6
 kernel tree

On Tue, Aug 05, 2014 at 01:55:34AM -0400, Nick Krause wrote:
> On Tue, Aug 5, 2014 at 1:45 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
> > On Tue, Aug 05, 2014 at 12:56:57AM -0400, Nicholas Krause wrote:
> >> I am adding the fixes to the tree send for adding debugging to the kernel
> >> tree from a patch sent in 2013 on the the 3.6 release. The patch adds
> >> debugging over xhci capable debugging usb ports and needed to be updated
> >> into the latest rc tree. The patch was first sent in this thread,
> >> http://marc.info/?l=linux-usb&m=135948845511047.
> >>
> >> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> >
> You haven't even checked my patch, our you just going to assume it's wrong?

If you spend 20 seconds reding what I quouted above you will find
bugs already.

1) No proper attribution
2) No proper description of the purpose of the patch

And considering the history of your formar patches
3) No documentation on how the patch was verified


There is no need to read the code with so many bugs in the changelog already.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/