linux-kernel - Re: [PATCH] sound/oss/opl3: Remove typedef opl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hd2cf6rk2.wl%tiwai@suse.de>
Date:	Tue, 05 Aug 2014 14:37:17 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Himangi Saraogi <himangi774@...il.com>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org, julia.lawall@...6.fr
Subject: Re: [PATCH] sound/oss/opl3: Remove typedef opl_devinfo

At Tue, 5 Aug 2014 17:37:18 +0530,
Himangi Saraogi wrote:
> 
> This typedef is unnecessary and should just be removed as they are
> never used.
> 
> The following Coccinelle semantic patch detects the case.
> 
> @tn@
> identifier i;
> type td;
> @@
> 
> -typedef
>  struct i { ... }
> -td
>  ;
> 
> @@
> type tn.td;
> identifier tn.i;
> @@
> 
> -td
> + struct i
> 
> Signed-off-by: Himangi Saraogi <himangi774@...il.com>
> Acked-by: Julia Lawall <julia.lawall@...6.fr>

Applied, thanks.


Takashi


> ---
>  sound/oss/opl3.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/oss/opl3.c b/sound/oss/opl3.c
> index 4709e59..607cee4 100644
> --- a/sound/oss/opl3.c
> +++ b/sound/oss/opl3.c
> @@ -52,7 +52,7 @@ struct voice_info
>  	int             panning;	/* 0xffff means not set */
>  };
>  
> -typedef struct opl_devinfo
> +struct opl_devinfo
>  {
>  	int             base;
>  	int             left_io, right_io;
> @@ -73,7 +73,7 @@ typedef struct opl_devinfo
>  	unsigned char   cmask;
>  
>  	int             is_opl4;
> -} opl_devinfo;
> +};
>  
>  static struct opl_devinfo *devc = NULL;
>  
> -- 
> 1.9.1
> 
1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/