linux-kernel - Re: [PATCH] arch/powerpc/mm/numa.c: Fix break placement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1407242394.11569.2.camel@concordia>
Date:	Tue, 05 Aug 2014 22:39:54 +1000
From:	Michael Ellerman <mpe@...erman.id.au>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	Andrey Utkin <andrey.krieger.utkin@...il.com>, paulus@...ba.org,
	akpm@...ux-foundation.org, srivatsa.bhat@...ux.vnet.ibm.com,
	sfr@...b.auug.org.au, qiuxishi@...wei.com,
	wangyun@...ux.vnet.ibm.com, qiudayu@...ux.vnet.ibm.com,
	joe@...ches.com, alistair@...ple.id.au, rcj@...ux.vnet.ibm.com,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] arch/powerpc/mm/numa.c: Fix break placement

On Tue, 2014-08-05 at 19:16 +1000, Benjamin Herrenschmidt wrote:
> On Mon, 2014-08-04 at 23:13 +0300, Andrey Utkin wrote:
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=81631
> > Reported-by: David Binderman <dcb314@...mail.com>
> > Signed-off-by: Andrey Utkin <andrey.krieger.utkin@...il.com>
> 
> Thanks, I wonder how that managed to remain unnoticed for so long !

1. No one tested it :)
2. The code stupidly initialises ret at the beginning of the function, so the
   compiler can't help us detect the unitialised usage.
3. NOTIFY_OK and NOTIFY_DONE appear to be equivalent in practice.

cheers



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/