| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 Aug 2014 15:34:28 +0200 From: Michal Hocko <mhocko@...e.cz> To: Johannes Weiner <hannes@...xchg.org> Cc: Andrew Morton <akpm@...ux-foundation.org>, Hugh Dickins <hughd@...gle.com>, linux-mm@...ck.org, cgroups@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [patch] mm: memcontrol: avoid charge statistics churn during page migration On Tue 05-08-14 09:12:23, Johannes Weiner wrote: > On Tue, Aug 05, 2014 at 02:24:34PM +0200, Michal Hocko wrote: > > On Mon 04-08-14 16:34:29, Johannes Weiner wrote: > > > Charge migration currently disables IRQs twice to update the charge > > > statistics for the old page and then again for the new page. > > > > > > But migration is a seemless transition of a charge from one physical > > > page to another one of the same size, so this should be a non-event > > > from an accounting point of view. Leave the statistics alone. > > > > Moving stats to mem_cgroup_commit_charge sounds logical to me but does > > this work properly even for the fuse replace page cache case when old > > and new pages can already live in different memcgs? > > We don't migrate if the new page is already charged. Right you are. Acked-by: Michal Hocko <mhocko@...e.cz> -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists