linux-kernel - Re: [PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1407245914.30675.31.camel@acox1-desk.ger.corp.intel.com>
Date:	Tue, 05 Aug 2014 14:38:34 +0100
From:	Alan Cox <alan@...ux.intel.com>
To:	Varka Bhadram <varkabhadram@...il.com>
Cc:	Matthias Brugger <matthias.bgg@...il.com>,
	linux-kernel@...r.kernel.org, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	rdunlap@...radead.org, gregkh@...uxfoundation.org, jslaby@...e.cz,
	grant.likely@...aro.org, heikki.krogerus@...ux.intel.com,
	paul.gortmaker@...driver.com, asierra@...-inc.com,
	mwelling@...e.org, dianders@...omium.org, m-karicheri2@...com,
	jschultz@...-inc.com, mingo@...e.hu, balbi@...com, heiko@...ech.de,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-serial@...r.kernel.org, linux-api@...r.kernel.org
Subject: Re: [PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

On Tue, 2014-08-05 at 17:34 +0530, Varka Bhadram wrote:
> On 08/05/2014 05:32 PM, Alan Cox wrote:
> > On Tue, 2014-08-05 at 17:25 +0530, Varka Bhadram wrote:
> >> On 08/05/2014 04:24 PM, Matthias Brugger wrote:
> >>
> >> (...)
> >>
> >>> +#include <linux/io.h>
> >>> +#include <linux/module.h>
> >>> +#include <linux/serial_8250.h>
> >>> +#include <linux/of_irq.h>
> >>> +#include <linux/of_platform.h>
> >>> +#include <linux/platform_device.h>
> >>> +#include <linux/clk.h>
> >>> +#include <linux/pm_runtime.h>
> >>> +#include "8250.h"
> >>> +
> >> Better if we have includes in alphabetical order..
> >
> > So 8250.h would be first and it wouldn't compile ???
> >
> > Can we stick to serious critiques ?
> 
> The local headers should be at the end of all includes

Which is not alaphetical order

The include ordering does not matter, please stick to actual things that
matter.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/