linux-kernel - Re: [PATCH v2] arch,locking: Ciao arch_mutex_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1407260539.6493.3.camel@buesod1.americas.hpqcorp.net>
Date:	Tue, 05 Aug 2014 10:42:19 -0700
From:	Davidlohr Bueso <davidlohr@...com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>,
	Aswin Chandramouleeswaran <aswin@...com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] arch,locking: Ciao arch_mutex_cpu_relax()

On Tue, 2014-08-05 at 15:04 +0200, Geert Uytterhoeven wrote:
> It looks like you forgot to update frv?  It's been failing on -next since a
> few days:
> 
> kernel/locking/mcs_spinlock.h:87:2: error: implicit declaration of
> function 'cpu_relax_lowlatency'
> [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> kernel/locking/mcs_spinlock.h:87:2: error: implicit declaration of
> function 'cpu_relax_lowlatency'
> [-Werror=implicit-function-declaration]
> make[3]: *** [kernel/locking/mcs_spinlock.o] Error 1
> cc1: some warnings being treated as errors
> make[3]: *** [kernel/locking/mutex.o] Error 1
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/11616307/

Ah, indeed. Thanks for the report, afaict this was the only missing
arch .

8<---------------------------------------------------------------
From: Davidlohr Bueso <davidlohr@...com>
Subject: [PATCH] frv: Define cpu_relax_lowlatency()

Fixes errors such as:

kernel/locking/mcs_spinlock.h:87:2: error: implicit declaration of function 'cpu_relax_lowlatency'

Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
Signed-off-by: Davidlohr Bueso <davidlohr@...com>
---
 arch/frv/include/asm/processor.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/frv/include/asm/processor.h b/arch/frv/include/asm/processor.h
index a34f309..6554e78 100644
--- a/arch/frv/include/asm/processor.h
+++ b/arch/frv/include/asm/processor.h
@@ -129,7 +129,8 @@ unsigned long get_wchan(struct task_struct *p);
 #define	KSTK_EIP(tsk)	((tsk)->thread.frame0->pc)
 #define	KSTK_ESP(tsk)	((tsk)->thread.frame0->sp)
 
-#define cpu_relax()    barrier()
+#define cpu_relax() barrier()
+#define cpu_relax_lowlatency() cpu_relax()
 
 /* data cache prefetch */
 #define ARCH_HAS_PREFETCH
-- 
1.8.1.4



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/