linux-kernel - Re: [PATCH net-next v4 4/4 RFC] pktgen: Allow sending IPv4 TCP packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 05 Aug 2014 13:09:01 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	zoltan.kiss@...rix.com
Cc:	steffen.klassert@...unet.com, minipli@...glemail.com,
	dborkman@...hat.com, tgraf@...g.ch, joe@...ches.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	xen-devel@...ts.xenproject.org
Subject: Re: [PATCH net-next v4 4/4 RFC] pktgen: Allow sending IPv4 TCP
 packets

From: Zoltan Kiss <zoltan.kiss@...rix.com>
Date: Mon, 4 Aug 2014 14:37:14 +0100

> @@ -3559,6 +3616,14 @@ static void pktgen_xmit(struct pktgen_dev *pkt_dev)
>  		pkt_dev->last_pkt_size = pkt_dev->skb->len;
>  		pkt_dev->allocated_skbs++;
>  		pkt_dev->clone_count = 0;	/* reset counter */
> +
> +		if (netif_needs_gso(pkt_dev->skb, netif_skb_features(pkt_dev->skb))) {
> +			pr_err("Device don't have necessary GSO features! netif_skb_features: %llX summed %u\n",
> +			       netif_skb_features(pkt_dev->skb),
> +			       pkt_dev->skb->ip_summed);
> +			pkt_dev->sofar++;
> +			goto out;
> +		}
>  	}
>  
>  	if (pkt_dev->delay && pkt_dev->last_ok)

Woe be to the person who actually triggers this condition.  This function
happens potentially millions of times per second, there is no value in
emitting a log message every time.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/