lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Wed, 6 Aug 2014 08:24:42 -0400
From:	Brian Foster <bfoster@...hat.com>
To:	Hans Wennborg <hans@...shq.net>
Cc:	david@...morbit.com, xfs@....sgi.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/15] xfs: fix decimal printf format specifiers prefixed
 with 0x

On Tue, Aug 05, 2014 at 09:44:16PM -0700, Hans Wennborg wrote:
> The prefix suggests the number should be printed in hex, so use
> the %x specifier to do that.
> 
> Found by using regex suggested by Joe Perches.
> 
> Signed-off-by: Hans Wennborg <hans@...shq.net>
> ---
>  fs/xfs/xfs_discard.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c
> index 13d08a1..b4a2415 100644
> --- a/fs/xfs/xfs_discard.c
> +++ b/fs/xfs/xfs_discard.c
> @@ -228,7 +228,7 @@ xfs_discard_extents(
>  				GFP_NOFS, 0);
>  		if (error && error != -EOPNOTSUPP) {
>  			xfs_info(mp,
> -	 "discard failed for extent [0x%llu,%u], error %d",
> +	 "discard failed for extent [0x%llx,%u], error %d",
>  				 (unsigned long long)busyp->bno,
>  				 busyp->length,
>  				 error);

It's kind of annoying seeing values of multiple bases being used to
describe a single extent, imo. But using 0x before a decimal value
certainly isn't nice... ;)

Reviewed-by: Brian Foster <bfoster@...hat.com>

> -- 
> 2.0.0.526.g5318336
> 
> _______________________________________________
> xfs mailing list
> xfs@....sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists