linux-kernel - Re: [PATCH] PCI: keystone: add a pci quirk to limit mrrs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140806163021.GB19914@obsidianresearch.com>
Date:	Wed, 6 Aug 2014 10:30:21 -0600
From:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:	Murali Karicheri <m-karicheri2@...com>
Cc:	linux-pci@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, bhelgaas@...gle.com
Subject: Re: [PATCH] PCI: keystone: add a pci quirk to limit mrrs

On Wed, Aug 06, 2014 at 11:18:20AM -0400, Murali Karicheri wrote:
> Keystone PCI controller has a limitation that memory read request
> size must not exceed 256 bytes. This is a hardware limitation and
> add a quirk to force this limit on all downstream devices by
> updating mrrs.

Does this still work if the tuning is enabled, or does the tuning run
after this?

> +			if (pcie_get_readrq(dev) > 256) {
> +				pr_info("limiting mrrs to 256\n");
> +				pcie_set_readrq(dev, 256);

The pr_info should either go away, or at least print the PCI bdf..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/