| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140806191834.GA12488@roeck-us.net> Date: Wed, 6 Aug 2014 12:18:34 -0700 From: Guenter Roeck <linux@...ck-us.net> To: David Wood <david@...ood.co.uk> Cc: Nick Krause <xerofoiffy@...il.com>, Mark Brown <broonie@...nel.org>, "open list:SPI SUBSYSTEM" <linux-spi@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>, Richard Weinberger <richard.weinberger@...il.com> Subject: Re: [PATCH] spi: Fix warning about redefinition On Wed, Aug 06, 2014 at 09:07:04PM +0200, David Wood wrote: > On 6 August 2014 21:04, Guenter Roeck <linux@...ck-us.net> wrote: > > On Wed, Aug 06, 2014 at 08:53:41PM +0200, David Wood wrote: > > ... > > That was purely to ensure that there is no hidden use through a macro > > defined elsewhere, not a suggestion for a real patch. > > > > Guenter > > I also managed not to notice that I had in fact shown that the fs.h > definitions were the opposite of those in the spi driver, so it would > in fact be significant if they were swapped. > See it positively: There is someone out there doing an excellent job of forcing various kernel maintainers to have a close look into areas of the kernel they would otherwise never look at. In addition to that, we all gain valuable knowledge on how to validate patches. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists