linux-kernel - Re: [PATCH 05/12] staging: lustre: Add missing spaces around operators and braces.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1407357106.2736.7.camel@joe-AO725>
Date:	Wed, 06 Aug 2014 13:31:46 -0700
From:	Joe Perches <joe@...ches.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	Andy Whitcroft <apw@...onical.com>
Cc:	Srikrishan Malik <srikrishanmalik@...il.com>, greg@...ah.com,
	andreas.dilger@...el.com, oleg.drokin@...el.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/12] staging: lustre: Add missing spaces around
 operators and braces.

On Wed, 2014-08-06 at 23:13 +0300, Dan Carpenter wrote:
> On Wed, Aug 06, 2014 at 10:42:55PM +0530, Srikrishan Malik wrote:
> > diff --git a/drivers/staging/lustre/lustre/mdc/mdc_reint.c b/drivers/staging/lustre/lustre/mdc/mdc_reint.c
[]
> > @@ -71,7 +71,7 @@ int mdc_resource_get_unused(struct obd_export *exp, const struct lu_fid *fid,
> >  			    __u64 bits)
> >  {
> >  	struct ldlm_namespace *ns = exp->exp_obd->obd_namespace;
> > -	ldlm_policy_data_t policy = {{0}};
> > +	ldlm_policy_data_t policy = {{0} };
> 
> That's odd.  Since when is a space required here?  Anyway, put one at
> the start too if you're goind to do that.  Or you could do it like:
> 
> 	ldlm_policy_data_t policy = {};
> 
> ?

It comes from a pretty old bit of checkpatch:

de7d4f0e (Andy Whitcroft 2007-07-15 23:37:22 -0700 3706) # closing brace should have a space following it when it has anything
de7d4f0e (Andy Whitcroft 2007-07-15 23:37:22 -0700 3707) # on the line
de7d4f0e (Andy Whitcroft 2007-07-15 23:37:22 -0700 3708)                if ($line =~ /}(?!(?:,|;|\)))\S/) {

Maybe it should have an } added to the test like:

if ($line =~ /}(?!(?:,|;|\)|}))\S/) {


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/