| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140806213651.GD22889@core.coreip.homeip.net> Date: Wed, 6 Aug 2014 14:36:51 -0700 From: Dmitry Torokhov <dmitry.torokhov@...il.com> To: Benjamin Tissoires <benjamin.tissoires@...hat.com> Cc: Ping Cheng <pinglinux@...il.com>, Jiri Kosina <jkosina@...e.cz>, Jason Gerecke <killertofu@...il.com>, Przemo Firszt <przemo@...szt.eu>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, linux-input <linux-input@...r.kernel.org> Subject: Re: [PATCH] Input - wacom: update the ABI doc according to latest changes On Wed, Aug 06, 2014 at 05:29:02PM -0400, Benjamin Tissoires wrote: > On Aug 06 2014 or thereabouts, Dmitry Torokhov wrote: > > On Wed, Aug 06, 2014 at 04:44:08PM -0400, Benjamin Tissoires wrote: > > > On Aug 05 2014 or thereabouts, Ping Cheng wrote: > > > > On Tue, Aug 5, 2014 at 2:34 PM, Benjamin Tissoires > > > > <benjamin.tissoires@...hat.com> wrote: > > > > > Hi Ping, > > > > > > > > > > On Aug 05 2014 or thereabouts, Ping Cheng wrote: > > > > >> Thank you Benjamin for updating the ABI docs. My comments are inline. > > > > >> > > > > >> With those lines updated, this patch is: > > > > >> > > > > >> Reviewed-by: Ping Cheng <pingc@...om.com> > > > > > > > > > > Thanks! > > > > > > > > > >> > > > > >> Cheers, > > > > >> > > > > >> Ping > > > > >> > > > > >> On Tue, Aug 5, 2014 at 8:34 AM, Benjamin Tissoires > > > > >> <benjamin.tissoires@...hat.com> wrote: > > > > >> > Now the devices show up under hid no matter the connection. So update the > > > > >> > sysfs path to the shortest and common one. > > > > >> > The ABI has also been unified regarding the OLEDs, but Bluetooth handle > > > > >> > only 1-bit images instead of 4. > > > > >> > > > > > >> > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com> > > > > >> > --- > > > > >> > > > > > >> > Guys, > > > > >> > > > > > >> > by updating this and working on the g-s-d client side for OLEDs, I think now > > > > >> > that we should also keep the oled*_img for Bluetooth and implement this file > > > > >> > for USB too. The user space code gets messy quite fast due to the need to > > > > >> > support old and new kernels, whereas if we handle the scrambling in the kernel, > > > > >> > it should be quite straightforward. > > > > >> > Of course, we have to keep the current button<n>_rawimg for backward > > > > >> > compatibility. > > > > >> > > > > > >> > Any thoughts? > > > > >> > > > > > >> > Cheers, > > > > >> > Benjamin > > > > >> > > > > > >> > Documentation/ABI/testing/sysfs-driver-wacom | 56 ++++++++++------------------ > > > > >> > 1 file changed, 20 insertions(+), 36 deletions(-) > > > > >> > > > > > >> > diff --git a/Documentation/ABI/testing/sysfs-driver-wacom b/Documentation/ABI/testing/sysfs-driver-wacom > > > > >> > index 7fc7810..c75ed4c 100644 > > > > >> > --- a/Documentation/ABI/testing/sysfs-driver-wacom > > > > >> > +++ b/Documentation/ABI/testing/sysfs-driver-wacom > > > > >> > @@ -1,47 +1,26 @@ > > > > >> > -WWhat: /sys/class/hidraw/hidraw*/device/oled*_img > > > > >> > -Date: June 2012 > > > > >> > -Contact: linux-bluetooth@...r.kernel.org > > > > >> > -Description: > > > > >> > - The /sys/class/hidraw/hidraw*/device/oled*_img files control > > > > >> > - OLED mocro displays on Intuos4 Wireless tablet. Accepted image > > > > >> > - has to contain 256 bytes (64x32 px 1 bit colour). The format > > > > >> > - is the same as PBM image 62x32px without header (64 bits per > > > > >> > - horizontal line, 32 lines). An example of setting OLED No. 0: > > > > >> > - dd bs=256 count=1 if=img_file of=[path to oled0_img]/oled0_img > > > > >> > - The attribute is read only and no local copy of the image is > > > > >> > - stored. > > > > >> > - > > > > >> > -What: /sys/class/hidraw/hidraw*/device/speed > > > > >> > +What: /sys/bus/hid/devices/<bus>:<vid>:<pid>.<n>/speed > > > > >> > Date: April 2010 > > > > >> > > > > >> Should the Date be updated? > > > > > > > > > > I don't think that this one should. The ABI is the same since April > > > > > 2010, and the "new" path works also for older kernels. So basically, > > > > > here, for Bluetooth, there has been no changes. > > > > > > > > Oh, I see your point. But, don't we consider path part of the interface? > > > > > > > > > > Well, in this case, both the path /sys/class/hidraw/hidraw*/device/speed > > > and /sys/bus/hid/devices/<bus>:<vid>:<pid>.<n>/speed refers to the same > > > device, even in April 2010. > > > > > > /sys/class/hidraw/hidraw*/device is IMO not accurate because you have to > > > check all the hidraw devices to find the right one. > > > /sys/bus/hid/devices/<bus>:<vid>:<pid>.<n>/speed gives you the correct > > > at first sight. This is just a fix to have a more reliable path in the > > > documentation, not a change. > > > > Can we document this in changelog? > > > > Hmm, yes. I guess I'll have to send a new version with this > documentation in the commit message and the update of the other dates. > > I should be offline for the next 3 to 4 hours, so it will have to wait > tonight or tomorrow morning. Well, it is a doc patch, it can go in at pretty much any time. > > BTW, thanks for merging the rest of the series (and the various > patches). Greatly appreciated. No, thank you for making them ;) Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists