linux-kernel - Re: [E1000-devel] PROBLEM: [x86] Running ptpd2 using an Intel 82572EI (e1000e) leads to a kernel oops (3.12.26)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1407364376.29652.3.camel@jekeller-desk1.amr.corp.intel.com>
Date:	Wed, 6 Aug 2014 22:32:56 +0000
From:	"Keller, Jacob E" <jacob.e.keller@...el.com>
To:	"Fujinaka, Todd" <todd.fujinaka@...el.com>
CC:	"hannes@...essinduktion.org" <hannes@...essinduktion.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"mathias.koehrer@...s.com" <mathias.koehrer@...s.com>
Subject: Re: [E1000-devel] PROBLEM: [x86] Running ptpd2 using an Intel
 82572EI (e1000e) leads to a kernel oops (3.12.26)

On Wed, 2014-08-06 at 15:38 +0000, Fujinaka, Todd wrote:
> Looking at your patches on netdev, it appears that there are flags set in the skb that should never be set for the 82572EI as that part doesn't have hardware timestamping. This points to a bug in the ptpd code.
> 
> Todd Fujinaka
> Software Application Engineer
> Networking Division (ND)
> Intel Corporation
> todd.fujinaka@...el.com
> (503) 712-4565


Surely we can bail here instead of generating a kernel oops? Even though
ptpd may be incorrect here, we still shouldn't do this. I think this may
be a bug in the set_ts_config possibly as well (since it shouldn't be
able to set the hardware timestamp flags for the 82572EI

Thanks,
Jake