linux-kernel - Re: [PATCHv2] Fix e1000e with Intel 82572EI that has no hardware timestamp support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1407393252.2244.1.camel@jtkirshe-mobl>
Date:	Wed, 06 Aug 2014 23:34:12 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	"Koehrer Mathias (ETAS/ESW5)" <mathias.koehrer@...s.com>
Cc:	Richard Cochran <richardcochran@...il.com>,
	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCHv2] Fix e1000e with Intel 82572EI that has no hardware
 timestamp support

On Thu, 2014-08-07 at 06:29 +0000, Koehrer Mathias (ETAS/ESW5) wrote:
> With the Intel 82527EI (driver: e1000e) there is an issue when running
> the ptpd2 program, that leads to a kernel oops.  The reason is here
> that
> in e1000_xmit_frame() a work queue will be scheduled that has not been
> initialized in this case.  The work queue "tx_hwstamp_work" will only
> be
> initialized if adapter->flags & FLAG_HAS_HW_TIMESTAMP set.  This check
> is missing in e1000_xmit_frame().
> 
> The following patch adds the missing check.
> 
> Signed-off-by: Mathias Koehrer <mathias.koehrer@...s.com>
> 
> ---
>  drivers/net/ethernet/intel/e1000e/netdev.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Thanks Mathias, I have added your patch to my queue for Dave's net tree.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)