linux-kernel - Re: linux-next: Tree for Aug 6 (sun6i-dma.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1407398174.3373.1.camel@paszta.hi.pengutronix.de>
Date:	Thu, 07 Aug 2014 09:56:14 +0200
From:	Philipp Zabel <p.zabel@...gutronix.de>
To:	Randy Dunlap <rdunlap@...radead.org>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	"dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
	Sugar <shuge@...winnertech.com>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>
Subject: Re: linux-next: Tree for Aug 6 (sun6i-dma.c)

Am Mittwoch, den 06.08.2014, 10:15 -0700 schrieb Randy Dunlap:
> On 08/06/14 09:42, Randy Dunlap wrote:
> > On 08/06/14 00:28, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> Please do not add code intended for v3.18 until after v3.17-rc1 is
> >> released.
> >>
> >> Changes since 20140805:
> >>
> > 
> > on x86_64:
> > when CONFIG_RESET_CONTROLLER is not enabled:
> > 
> > ../drivers/dma/sun6i-dma.c: In function 'sun6i_dma_probe':
> > ../drivers/dma/sun6i-dma.c:911:2: error: implicit declaration of function 'devm_reset_control_get' [-Werror=implicit-function-declaration]
> > 
> > Add a stub for that function?

There is no stub for this function by choice.
Drivers that can accept stubbed out CONFIG_RESET_CONTROLLER functions
should use devm_reset_control_get_optional instead.

> or that driver's Kconfig entry could select RESET_CONTROLLER.

Yes, please.

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/