[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1407374021-20682-1-git-send-email-xerofoiify@gmail.com>
Date: Thu, 7 Aug 2014 03:13:41 +0200
From: Nick Krause <xerofoiify@...il.com>
To: Arnd Bergmann <arnd@...db.de>,
linux-arch@...r.kernel.org (open list:GENERIC INCLUDE/A...),
linux-kernel@...r.kernel.org (open list)
Cc: josh@...htriplett.org
Subject: [PATCH 1/1] bug: Add unreachable() to generic BUG() to silence warnings
Architectures which use generic BUG() have warnings like
kernel/sched/core.c:2692:1: warning: control reaches end of non-void function [-Wreturn-type]
net/core/ethtool.c:236:1: warning: control reaches end of non-void function [-Wreturn-type]
Other BUG() implementations
have added unreachable() at end but generic does not. I guess
that is why
it showing these errors. We can silence them using unreachable().
Signed-off-by: Nick Krause <xerofoify@...il.com>
---
include/asm-generic/bug.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
index 630dd23..effcc82 100644
--- a/include/asm-generic/bug.h
+++ b/include/asm-generic/bug.h
@@ -48,6 +48,7 @@ struct bug_entry {
#define BUG() do { \
printk("BUG: failure at %s:%d/%s()!\n", __FILE__, __LINE__, __func__); \
panic("BUG!"); \
+ unreachable(); \
} while (0)
#endif
--
2.0.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists