lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 7 Aug 2014 10:54:26 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Andrzej Hajda <a.hajda@...sung.com>
Cc:	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	YoungJun Cho <yj44.cho@...sung.com>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	Ajay Kumar <ajaykumar.rs@...sung.com>,
	dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: Dual-channel DSI

On Thu, Aug 07, 2014 at 10:39:36AM +0200, Andrzej Hajda wrote:
> On 08/07/2014 09:25 AM, Thierry Reding wrote:
> > On Thu, Aug 07, 2014 at 08:53:47AM +0200, Andrzej Hajda wrote:
> >> Hi Thierry,
> >>
> >> Nice case.
> >>
> >> On 08/05/2014 05:39 PM, Thierry Reding wrote:
> >>> Hi everyone,
> >>>
> >>> I've been working on adding support for a panel that uses what's
> >>> commonly known as dual-channel DSI. Sometimes this is referred to as
> >>> ganged-mode as well.
> >>>
> >>> What is it, you ask? It's essentially a hack to work around the band-
> >>> width restrictions of DSI, albeit one that's been commonly implemented
> >>> by several SoC vendors.
> >>>
> >>> This typically works by equipping a peripheral with two DSI interfaces,
> >>> each of which driving one half of the screen (symmetric left-right mode)
> >>> or every other line (symmetric odd-even mode). Apparently there can be
> >>> asymmetric modes in addition to those two, but they seem to be the
> >>> common ones. Often both of the DSI interfaces need to be configured
> >>> using DCS commands and vendor specific registers.
> >>>
> >>> A single display controller is typically used video data transmission.
> >>> This is necessary to provide synchronization and avoid tearing and all
> >>> kinds of other ugliness. For this to work both DSI controllers need to
> >>> be made aware of which chunk of the video data stream is addressing
> >>> them.
> >>>
> >>> From a software perspective, this poses two problems:
> >>>
> >>> 1) A dual-channel device is composed of two DSI peripheral devices which
> >>>    cannot be programmed independently of each other. A typical example
> >>>    is that the frame memory extents need to be configured differently
> >>>    for each of the devices (using the DCS set_column_address and
> >>>    set_page_address commands). Therefore each device must know of the
> >>>    other, or there must be a driver that binds against a dummy device
> >>>    that pulls in the two real devices.
> >> I am not sure if I understand correctly, but I see it rather as one
> >> device with two dsi-slave interfaces. Probably panel driver can
> >> create dsi dummy device to program some registers
> >> via second dsi interface but the panel will be attached to one control bus.
> >> It seems to be very similar to mfd/i2c devices with two or more i2c
> >> addresses.
> > They are in fact attached to two different control busses. The DSI
> > controllers that talk to each are separate. On Tegra they are the same
> > type of IP block, but still two separate instances (with their own
> > clock, reset, etc. inputs).
> >
> > So the panel driver can't create a dummy device to talk to the second
> > DSI interface because the second DSI interface uses a different DSI
> > host.
> 
> Why different DSI host does not allow that? The only thing panel needs
> is the reference to another DSI host and this can be provided via
> DT direct phandle or video interface.

I'm sure one could find ways to make it work. That doesn't mean it's a
good idea, though. The second peripheral is physically there on the
second DSI host controller's bus, so it the device should be in device
tree because so that the device tree matches reality.

> >>> 2) On the DSI host side, each of the controller instances needs to know
> >>>    the intimate details of the other controller (or alternatively, one
> >>>    controller needs to be a "master" and the other a "slave").
> >> The question is if they need to communicate each other, or they have
> >> to have similar configurations applied?
> > On Tegra at least the configuration needs to be almost the same. There
> > are two registers that may need to be programmed differently. But they
> > don't have to communicate with each other. Essentially the two registers
> > that require different programming define which parts of the display
> > controller's data stream they need to capture and turn into DSI packets.
> >
> > Theoretically it would be possible to make this work with two completely
> > different DSI controllers, but in practice I'd expect that to never
> > happen. So I'm not sure we need to consider the case where the register
> > layout is different between the two DSI host controllers.
> 
> So maybe the configuration could be provided by the panel.

What configuration? I suppose one idea would be for the panel driver to
set the type of dual-channel mode that it's using. Panels can typically
be configured to do symmetric left-right or symmetric odd-even. I think
technically it's possible to have asymmetric modes, too, but to be
honest I don't want to think about those yet.

So I think it's reasonable for the DSI device to provide information as
to what mode it's using. Perhaps that could be done as part of the slave
setup.

> > I've come up with another alternative that works:
> >
> > 	dsi@...00000 {
> > 		panel: panel@0 {
> > 			compatible = "sharp,lq101r1sx01";
> > 			reg = <0>;
> > 		};
> > 	};
> >
> > 	dsi@...00000 {
> > 		panel@0 {
> > 			compatible = "sharp,lq101r1sx01";
> > 			reg = <0>;
> >
> > 			master = <&panel>;
> > 		};
> > 	};
> 
> But here you have again two compatibles and two devices in DT representing
> one HW device.

Because that's what they really are. There are two different devices,
it's just that they happen to be driving two separate halves of the same
panel.

> I am not sure if it is better. If you do not like video
> interfaces
> maybe better would be sth like this:
> 
> 	dsi@...00000 {
> 		panel: panel@0 {
> 			compatible = "sharp,lq101r1sx01";
> 			reg = <0>;
> 			secondary_dsi = <&dsiB>;
>  		};
> 	};
> 
> 	dsiB: dsi@...00000 {
> 	};

That's pretty much the same thing that I proposed, except that it
reverses the link between the two. In fact I tried something similar to
that before, but it has a couple of problems: if the secondary device
does not have a compatible string (that's probably not valid in device
tree to begin with) then there's no way for the device to report what
format it expects or what number of lanes it uses. But those are
parameters that are needed to set up the DSI (and display controllers).

One other problem with the above is that the dependency implied by your
"secondary_dsi" property is the wrong way around. The above would mean
that &panel requires &dsiB's services to function, but that's not the
case. If anything it's the other way around. &panel could still work
standalone (though only drive the left half of the screen).

Thierry

Content of type "application/pgp-signature" skipped

Powered by blists - more mailing lists