lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Thu, 07 Aug 2014 11:15:48 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Oussama Jabbari <oussama.jabbari@...il.com>
CC:	gregkh@...uxfoundation.org, sachin.kamat@...aro.org,
	lars@...afoo.de, linux-iio@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: iio: adis16060: Fix coding style problem

On 06/08/14 18:06, Oussama Jabbari wrote:
> This patch fixes a warning from checkpatch.pl script :
> "WARNING: Missing a blank line after declarations"
> 
> Signed-off-by: Oussama Jabbari <oussama.jabbari@...il.com>
Whilst I find it hard to care about this particular issue,
I'm accepting this mainly to avoid getting the same thing
sometime in the future!

Anyhow, a nicely formatted patch.  The only change I would
have suggested would be in the title which might as be more
specific.

[PATCH] staging:iio:adis16060 Add missing blank line after declaration.

Applied to the togreg branch of iio.git - initially pushed out as
testing for the autobuilders to play with it.

J
> ---
> The reason of this patch is for completing one task
> of the Eudyptula Challenge.
> 
>  drivers/staging/iio/gyro/adis16060_core.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/iio/gyro/adis16060_core.c b/drivers/staging/iio/gyro/adis16060_core.c
> index d5d395c..4c5869d 100644
> --- a/drivers/staging/iio/gyro/adis16060_core.c
> +++ b/drivers/staging/iio/gyro/adis16060_core.c
> @@ -180,6 +180,7 @@ static int adis16060_w_probe(struct spi_device *spi)
>  	int ret;
>  	struct iio_dev *indio_dev = adis16060_iio_dev;
>  	struct adis16060_state *st;
> +
>  	if (!indio_dev) {
>  		ret =  -ENODEV;
>  		goto error_ret;
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists