linux-kernel - Re: [PATCH] staging/lustre: use rcu_dereference to access rcu protected current->real

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGDhxoe4+jU=vCDedMC4VXfuNMmqP3-E1Lu3LLStbFLbd=BRSA@mail.gmail.com>
Date:	Thu, 7 Aug 2014 14:13:50 +0300
From:	Evgeny Budilovsky <budevg@...il.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Andreas Dilger <andreas.dilger@...el.com>,
	Oleg Drokin <green@...uxhacker.ru>,
	Peng Tao <bergwolf@...il.com>, Lai Siyao <lai.siyao@...el.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging/lustre: use rcu_dereference to access rcu
 protected current->real_parent field

On Thu, Aug 7, 2014 at 12:42 AM, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
> On Wed, Aug 06, 2014 at 09:22:43PM +0300, Evgeny Budilovsky wrote:
>>
>>
>> Signed-off-by: Evgeny Budilovsky <budevg@...il.com>
>
> Why is this needed?  Is the current code a bug?  Where was the reference
> added?  Is this causing a problem without this patch applied?  How far
> back should it be backported, if at all?
>
> I need lots more details here before I can take this patch, sorry.

Sorry for the little information in the previous mail.

The motivation for this patch was to clean some of the warnings that
were generated
on drivers/staging by the sparse utility.

For this particular case the warning was
staging/lustre/lustre/llite/lproc_llite.c:913:51: warning: dereference
of noderef expression

And this is since current->real_parent is accessed directly and not
trough the rcu_dereference,
which is the common way to access it throughout the kernel.

This is not a critical bug and in the worst case the code here may
cause miss of statistics counter increase.
This is why I think it is not worth to backport the patch at all.

>
> greg k-h



-- 
Best Regards,
Evgeny
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/