linux-kernel - Re: linux-next: Tree for Aug 6 (sun6i-dma.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140807140000.GH8181@intel.com>
Date:	Thu, 7 Aug 2014 19:30:01 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Maxime Ripard <maxime.ripard@...e-electrons.com>
Cc:	Philipp Zabel <p.zabel@...gutronix.de>,
	Randy Dunlap <rdunlap@...radead.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	"dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
	Sugar <shuge@...winnertech.com>
Subject: Re: linux-next: Tree for Aug 6 (sun6i-dma.c)

On Thu, Aug 07, 2014 at 01:25:07PM +0200, Maxime Ripard wrote:
> On Thu, Aug 07, 2014 at 09:56:14AM +0200, Philipp Zabel wrote:
> > Am Mittwoch, den 06.08.2014, 10:15 -0700 schrieb Randy Dunlap:
> > > On 08/06/14 09:42, Randy Dunlap wrote:
> > > > On 08/06/14 00:28, Stephen Rothwell wrote:
> > > >> Hi all,
> > > >>
> > > >> Please do not add code intended for v3.18 until after v3.17-rc1 is
> > > >> released.
> > > >>
> > > >> Changes since 20140805:
> > > >>
> > > > 
> > > > on x86_64:
> > > > when CONFIG_RESET_CONTROLLER is not enabled:
> > > > 
> > > > ../drivers/dma/sun6i-dma.c: In function 'sun6i_dma_probe':
> > > > ../drivers/dma/sun6i-dma.c:911:2: error: implicit declaration of function 'devm_reset_control_get' [-Werror=implicit-function-declaration]
> > > > 
> > > > Add a stub for that function?
> > 
> > There is no stub for this function by choice.
> > Drivers that can accept stubbed out CONFIG_RESET_CONTROLLER functions
> > should use devm_reset_control_get_optional instead.
> > 
> > > or that driver's Kconfig entry could select RESET_CONTROLLER.
> > 
> > Yes, please.
> 
> A depends on would be better I guess.
Patch pls :)

-- 
~Vinod


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)