linux-kernel - Re: [PATCH 10/12] staging: lustre: Fix misplaced opening brace warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140807153136.GB4185@mordor.in.ibm.com>
Date:	Thu, 7 Aug 2014 21:01:36 +0530
From:	Srikrishan Malik <srikrishanmalik@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	greg@...ah.com, andreas.dilger@...el.com, oleg.drokin@...el.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/12] staging: lustre: Fix misplaced opening brace
 warnings

On Wed, Aug 06, 2014 at 11:18:13PM +0300, Dan Carpenter wrote:
> On Wed, Aug 06, 2014 at 10:43:00PM +0530, Srikrishan Malik wrote:
> > diff --git a/drivers/staging/lustre/lustre/mdc/mdc_locks.c b/drivers/staging/lustre/lustre/mdc/mdc_locks.c
> > index c03d77c9c5b8..09209171b50c 100644
> > --- a/drivers/staging/lustre/lustre/mdc/mdc_locks.c
> > +++ b/drivers/staging/lustre/lustre/mdc/mdc_locks.c
> > @@ -785,12 +785,12 @@ int mdc_enqueue(struct obd_export *exp, struct ldlm_enqueue_info *einfo,
> >  	__u64		  flags, saved_flags = extra_lock_flags;
> >  	int		    rc;
> >  	struct ldlm_res_id res_id;
> > -	static const ldlm_policy_data_t lookup_policy =
> > -			    { .l_inodebits = { MDS_INODELOCK_LOOKUP } };
> > -	static const ldlm_policy_data_t update_policy =
> > -			    { .l_inodebits = { MDS_INODELOCK_UPDATE } };
> > -	static const ldlm_policy_data_t layout_policy =
> > -			    { .l_inodebits = { MDS_INODELOCK_LAYOUT } };
> > +	static const ldlm_policy_data_t lookup_policy = {
> > +				.l_inodebits = { MDS_INODELOCK_LOOKUP } };
> > +	static const ldlm_policy_data_t update_policy = {
> > +				.l_inodebits = { MDS_INODELOCK_UPDATE } };
> > +	static const ldlm_policy_data_t layout_policy = {
> > +				.l_inodebits = { MDS_INODELOCK_LAYOUT } };
> >  	static const ldlm_policy_data_t getxattr_policy = {
> >  			      .l_inodebits = { MDS_INODELOCK_XATTR } };
> >  	ldlm_policy_data_t const *policy = &lookup_policy;
> 
> That looks silly before and after.  Everything is indented in a funny
> way.

Is this better:

	static const ldlm_policy_data_t lookup_policy = {                       
				.l_inodebits = { MDS_INODELOCK_LOOKUP }         
	};

> 
> regards,
> dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/