lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 07 Aug 2014 18:44:18 +0200
From:	Bartlomiej Zolnierkiewicz <>
To:	Samuel Ortiz <>,
	Lee Jones <>
Cc:	Krzysztof Kozlowski <>,
	Sangbeom Kim <>,
	Kyungmin Park <>,
Subject: [PATCH] mfd: sec-core: add missing sec_irq_init() return value checking

sec_irq_init() can fail if it encounters unknown device type or
on regmap_add_irq_chip() error.  Add missing sec_irq_init() return
value checking to sec_pmic_probe().

Tested on Insignal's Exynos4412 based Origen board.

Cc: Krzysztof Kozlowski <>
Cc: Sangbeom Kim <>
Signed-off-by: Bartlomiej Zolnierkiewicz <>
Acked-by: Kyungmin Park <>
patch is against next-20140804 branch of linux-next kernel

 drivers/mfd/sec-core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
index dba7e2b..f498867 100644
--- a/drivers/mfd/sec-core.c
+++ b/drivers/mfd/sec-core.c
@@ -353,7 +353,9 @@ static int sec_pmic_probe(struct i2c_client *i2c,
 	if (pdata && pdata->cfg_pmic_irq)
-	sec_irq_init(sec_pmic);
+	ret = sec_irq_init(sec_pmic);
+	if (ret)
+		return ret;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists