linux-kernel - Re: sel_netif_init: 'err' is used uninitialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140807.120454.1646328149054855088.davem@davemloft.net>
Date:	Thu, 07 Aug 2014 12:04:54 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	paul@...l-moore.com
Cc:	geert@...ux-m68k.org, linux-security-module@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: sel_netif_init: 'err' is used uninitialized

From: Paul Moore <paul@...l-moore.com>
Date: Thu, 07 Aug 2014 10:26:14 -0400

> On Thursday, August 07, 2014 12:31:15 PM Geert Uytterhoeven wrote:
>> 
>> security/selinux/netif.c: In function ‘sel_netif_init’:
>> /scratch/geert/linux/linux-m68k/security/selinux/netif.c:285: warning:
>> ‘err’ is used uninitialized in this function
>> 
>> Should it just return 0, like before?
>> Or should it return the return value of register_netdevice_notifier()
>> instead, which also returns an error code? Or is that failure non-critical?
> 
> Hi,
> 
> I posted a fix for this two days ago to the SELinux list (see below).  As soon 
> as -rc1 is released and linux-next is back in business I'll be pushing the 
> patch to the SELinux #next branch.
> 
>  * http://marc.info/?l=selinux&m=140727033030054&w=2

With respect to this and the lack-of-inline warning fix we spoke about
yesterday, why are you waiting and only pushing such bug fixes into your
"next" branch?

Those sort of things should be sent to Linus now to correct the errors
introduced during the merge window, as I have done last night for all
of the networking merge fallout.