lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 7 Aug 2014 21:38:24 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Josh Triplett <josh@...htriplett.org>
Cc:	akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
	David Rientjes <rientjes@...gle.com>,
	"Luis R. Rodriguez" <mcgrof@...e.com>,
	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] x86: Add "make tinyconfig" to configure the tiniest
 possible kernel

> 
> > > diff --git a/arch/x86/configs/tiny.config b/arch/x86/configs/tiny.config
> > > new file mode 100644
> > > index 0000000..8f0e54c
> > > --- /dev/null
> > > +++ b/arch/x86/configs/tiny.config
> > > @@ -0,0 +1,5 @@
> > > +CONFIG_CC_OPTIMIZE_FOR_SIZE=y
> > > +CONFIG_KERNEL_XZ=y
> > > +CONFIG_NOHIGHMEM=y
> > > +CONFIG_OPTIMIZE_INLINING=y
> > > +CONFIG_SLOB=y
> > All the above are general options that apply equal to arm than to x86.
> 
> NOHIGHMEM isn't.
You are right - as it is x86 specific it should had been prefixed
with X86_ to document so.

As the symbol is only relevant for X86 it will not hurt anyone else,
so it is OK to have it.
But it would be nice to document in tiny.config that
this is a X86 specific symbol.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists