linux-kernel - Re: [PATCH v3] kbuild: kselftest - new make target to build and run kernel selftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140807201835.GA2503@ravnborg.org>
Date:	Thu, 7 Aug 2014 22:18:35 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Shuah Khan <shuah.kh@...sung.com>
Cc:	mmarek@...e.cz, gregkh@...uxfoundation.org,
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] kbuild: kselftest - new make target to build and run
 kernel selftests

On Thu, Aug 07, 2014 at 01:07:46PM -0600, Shuah Khan wrote:
> Add a new make target "kselftest" to enable kernel testing. This
> new target builds and runs kernel selftests. Running as root is
> recommended for a complete test run as some tests don't run when
> run by non-root user. Build, install, and boot kernel before
> running kselftest on it.
> 
> Signed-off-by: Shuah Khan <shuah.kh@...sung.com>
> ---
>  Makefile | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index d0901b4..574e8da 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1036,6 +1036,13 @@ headers_check: headers_install
>  	$(Q)$(MAKE) $(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) HDRCHECK=1
>  
>  # ---------------------------------------------------------------------------
> +# Kernel selftest
> +
> +PHONY += kselftest
> +kselftest:
> +	$(Q)$(MAKE) -C tools/testing/selftests run_tests
> +
> +# ---------------------------------------------------------------------------
>  # Modules
>  
>  ifdef CONFIG_MODULES
> @@ -1238,6 +1245,11 @@ help:
>  	@echo  '  headerdep       - Detect inclusion cycles in headers'
>  	@$(MAKE) -f $(srctree)/scripts/Makefile.help checker-help
>  	@echo  ''
> +	@echo  'Kernel selftest'
> +	@echo  '  kselftest       - Build and run kernel selftest (run as root)'
> +	@echo  '                    Build, install, and boot kernel before'
> +	@echo  '                    running kselftest on it'
It is never good to advertise to run something as root.
But I see that this is recommended for now so the patch has my:
Acked-by: Sam Ravnborg <sam@...nborg.org>

	Sam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/