linux-kernel - Re: [PATCH] i2c: rk3x: fix interrupt handling issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 08 Aug 2014 12:15:11 +0200
From:	Heiko Stübner <heiko@...ech.de>
To:	Addy Ke <addy.ke@...k-chips.com>
Cc:	wsa@...-dreams.de, max.schwarz@...ine.de, olof@...om.net,
	dianders@...omium.org, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org, cf@...k-chips.com,
	xjq@...k-chips.com, huangtao@...k-chips.com, zyw@...k-chips.com,
	yzq@...k-chips.com, hj@...k-chips.com, kever.yang@...k-chips.com,
	hl@...k-chips.com, caesar.wang@...k-chips.com,
	zhengsq@...k-chips.com
Subject: Re: [PATCH] i2c: rk3x: fix interrupt handling issue

Am Freitag, 8. August 2014, 17:41:40 schrieb Addy Ke:
> If slave holds scl, I2C_IPD[7] will be set 1 by controller
> for debugging. Driver must ignore it.
> 
> [    5.752391] rk3x-i2c ff160000.i2c: unexpected irq in WRITE: 0x80
> [    5.939027] rk3x-i2c ff160000.i2c: timeout, ipd: 0x80, state: 4
> 
> Signed-off-by: Addy Ke <addy.ke@...k-chips.com>

I checked the manuals, bits [31:7] are marked as reserved in all of them, so

Reviewed-by: Heiko Stuebner <heiko@...ech.de>

> ---
>  drivers/i2c/busses/i2c-rk3x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> index 9e3084c..eab49e6 100644
> --- a/drivers/i2c/busses/i2c-rk3x.c
> +++ b/drivers/i2c/busses/i2c-rk3x.c
> @@ -399,7 +399,7 @@ static irqreturn_t rk3x_i2c_irq(int irqno, void *dev_id)
> }
> 
>  	/* is there anything left to handle? */
> -	if (unlikely(ipd == 0))
> +	if (unlikely((ipd & REG_INT_ALL) == 0))
>  		goto out;
> 
>  	switch (i2c->state) {

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/