lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Fri,  8 Aug 2014 12:07:45 +0200
From:	Julia Lawall <>
To:	Benjamin Herrenschmidt <>
Cc:, Paul Mackerras <>,
	Michael Ellerman <>,,,
	Uwe Kleine-König 
Subject: [PATCH 6/14] powerpc/fsl: fsl_soc: delete unneeded test before of_node_put

From: Julia Lawall <>

Of_node_put supports NULL as its argument, so the initial test is not

Suggested by Uwe Kleine-König.

The semantic patch that fixes this problem is as follows:

// <smpl>
expression e;

-if (e)
// </smpl>

Signed-off-by: Julia Lawall <>

 arch/powerpc/sysdev/fsl_soc.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/fsl_soc.c
index ffd1169..bfb5b6c 100644
--- a/arch/powerpc/sysdev/fsl_soc.c
+++ b/arch/powerpc/sysdev/fsl_soc.c
@@ -197,8 +197,7 @@ static int __init setup_rstcr(void)
 	if (!rstcr && ppc_md.restart == fsl_rstcr_restart)
 		printk(KERN_ERR "No RSTCR register, warm reboot won't work\n");
-	if (np)
-		of_node_put(np);
+	of_node_put(np);
 	return 0;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists