lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 7 Aug 2014 19:18:13 -0700 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Martin Berglund <martin@...sta.net> Cc: Forest Bond <forest@...ttletooquiet.net>, Guido MartÃnez <guido@...guardiasur.com.ar>, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: vt6655: wpactl.c: Fix sparse warnings On Thu, Aug 07, 2014 at 11:08:34PM +0100, Martin Berglund wrote: > Add missing __user macro casting in the function wpa_set_keys. > This is okay since the function handles the possibility of > param->u.wpa_key.key and param->u.wpa_key.seq pointing to > kernelspace using a flag, fcpfkernel. > > Signed-off-by: Martin Berglund <martin@...sta.net> > --- > This was submitted as part of Eudyptula challenge task 16 > > drivers/staging/vt6655/wpactl.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/vt6655/wpactl.c b/drivers/staging/vt6655/wpactl.c > index 5f454ca..d75dd79 100644 > --- a/drivers/staging/vt6655/wpactl.c > +++ b/drivers/staging/vt6655/wpactl.c > @@ -224,7 +224,9 @@ int wpa_set_keys(PSDevice pDevice, void *ctx, > } else { > spin_unlock_irq(&pDevice->lock); > if (param->u.wpa_key.key && > - copy_from_user(&abyKey[0], param->u.wpa_key.key, param->u.wpa_key.key_len)) { > + copy_from_user(&abyKey[0], > + (void __user *)param->u.wpa_key.key, Would it be better to mark this pointer as __user in the structure itself? Or is it also used as a kernel structure in other places? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists