linux-kernel - Re: [PATCH 1/2] Input: da9055_onkey: Remove unnecessary OOM meassage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 8 Aug 2014 09:26:54 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Kiran Padwal <kiran.padwal@...rtplayin.com>
Cc:	support.opensource@...semi.com,
	anthony.olech.opensource@...semi.com, david.chen@...semi.com,
	kiran.padwal21@...il.com, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Input: da9055_onkey: Remove unnecessary OOM meassage

On Fri, Aug 08, 2014 at 12:44:57PM +0530, Kiran Padwal wrote:
> There is no need to print out-of-memory errors since this is already
> done by the memory management subsystem which even calls dump_stack().

This is implementation detail as far as I am concerned. We might switch
dumping stack off down the road.

Thanks.

> 
> Signed-off-by: Kiran Padwal <kiran.padwal@...rtplayin.com>
> ---
>  drivers/input/misc/da9055_onkey.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/input/misc/da9055_onkey.c b/drivers/input/misc/da9055_onkey.c
> index 4765799..ed6eaa9 100644
> --- a/drivers/input/misc/da9055_onkey.c
> +++ b/drivers/input/misc/da9055_onkey.c
> @@ -87,10 +87,8 @@ static int da9055_onkey_probe(struct platform_device *pdev)
>  	}
>  
>  	onkey = devm_kzalloc(&pdev->dev, sizeof(*onkey), GFP_KERNEL);
> -	if (!onkey) {
> -		dev_err(&pdev->dev, "Failed to allocate memory\n");
> +	if (!onkey)
>  		return -ENOMEM;
> -	}
>  
>  	input_dev = input_allocate_device();
>  	if (!input_dev) {
> -- 
> 1.7.9.5
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/