lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 08 Aug 2014 17:36:25 +0100 From: Pawel Moll <pawel.moll@....com> To: Chris Ball <chris@...ntf.net>, Anton Vorontsov <anton@...msg.org>, Ulf Hansson <ulf.hansson@...aro.org> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Olof Johansson <olof@...om.net>, Stephen Warren <swarren@...dotorg.org>, Catalin Marinas <Catalin.Marinas@....com>, "paul@...an.com" <paul@...an.com>, Arnd Bergmann <arnd@...db.de>, Peter De Schrijver <pdeschrijver@...dia.com>, "arm@...nel.org" <arm@...nel.org>, "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>, "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org> Subject: Re: [PATCH 3/5] mmc: sdhci-pltfm: Do not use parent as the host's device On Fri, 2014-07-25 at 15:23 +0100, Pawel Moll wrote: > The code selecting a device for the sdhci host has been > continuously tweaked (4b711cb13843f5082e82970dd1e8031383134a65 > "mmc: sdhci-pltfm: Add structure for host-specific data" and > a4d2177f00a5252d825236c5124bc1e9918bdb41 "mmc: sdhci-pltfm: dt > device does not pass parent to sdhci_alloc_host") while there > does not seem to be any reason to use platform device's parent > in the first place. > > The comment saying "Some PCI-based MFD need the parent here" > seem to refer to Timberdale FPGA driver (the only MFD driver > registering SDHCI cell, drivers/mfd/timberdale.c) but again, > the only situation when parent device matter is runtime PM, > which is not implemented for Timberdale. > > Cc: Chris Ball <chris@...ntf.net> > Cc: Anton Vorontsov <anton@...msg.org> > Cc: Ulf Hansson <ulf.hansson@...aro.org> > Cc: linux-mmc@...r.kernel.org > Cc: linuxppc-dev@...ts.ozlabs.org > Signed-off-by: Pawel Moll <pawel.moll@....com> > --- > > This patch is a part of effort to remove references to platform_bus > and make it static. > > Chris, Anton, Ulf - could you please advise if the assumptions > above are correct or if I'm completely wrong? Do you know what > where the real reasons to use parent originally? The PCI comment > seems like a red herring to me... Can I take the silence as a suggestion that the change looks ok-ish for you? Paweł -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists