linux-kernel - Re: [PATCH 1/3] of: Add of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 8 Aug 2014 14:01:57 -0500
From:	Rob Herring <robherring2@...il.com>
To:	Tuomas Tynkkynen <ttynkkynen@...dia.com>
Cc:	Thierry Reding <thierry.reding@...il.com>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	Stephen Warren <swarren@...dotorg.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Subject: Re: [PATCH 1/3] of: Add of_match_machine helper

On Fri, Aug 8, 2014 at 8:23 AM, Tuomas Tynkkynen <ttynkkynen@...dia.com> wrote:
>
>
> On 08/08/14 12:41, Thierry Reding wrote:
>>
>>> +const struct of_device_id *of_match_machine(const struct of_device_id *matches)
>>> +{
>>> +    const struct of_device_id *match;
>>> +    struct device_node *root;
>>> +
>>> +    root = of_find_node_by_path("/");
>>> +    if (!root)
>>> +            return NULL;
>>> +
>>> +    match = of_match_node(matches, root);
>>> +    of_node_put(root);
>>> +    return match;
>>> +}
>>> +EXPORT_SYMBOL(of_match_machine);
>>
>> I wonder if of_find_node_by_path("/") is somewhat overkill here. Perhaps
>> simply of_node_get(of_allnodes) would be more appropriate here since the
>> function is implemented in the core?
>
> of_machine_is_compatible() uses of_find_node_by_path("/") as well, of_allnodes
> seems to be only used when during iterating. So I'd prefer to have them
> consistent.

Agreed.

For the series:

Acked-by: Rob Herring <robh@...nel.org>

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/